Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default for entry_points_for_group and handle edge case in URI's #72

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

MHendricks
Copy link
Member

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

  • If you passed the URI app/ with anytree<2.9.0 installed it would raise an IndexError: list index out of range error. This sanitizes that by removing trailing slashes.
  • Adds a way to easily specify default entry points that get cast to importlib_metadata.EntryPoint when using Site.entry_points_for_group.

@MHendricks MHendricks merged commit 34a5792 into main Sep 21, 2023
23 checks passed
@MHendricks MHendricks deleted the mikeh/anytree_bug branch September 21, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant