Add caching mechanism to speed up loading #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MHendricks
force-pushed
the
mikeh/site_cache
branch
5 times, most recently
from
92896fc to
d29d82f
Compare
MHendricks
force-pushed
the
mikeh/site_cache
branch
7 times, most recently
from
871df2c to
583ac60
Compare
MHendricks
force-pushed
the
mikeh/site_cache
branch
3 times, most recently
from
48a44fa to
1b4b474
Compare
The slowest part of using the hab cli is the globing of config/distro paths(especially for network paths on windows). Individually parsing hundreds of json files also is slower than parsing a single json file containing the same data, which caching helps out with.
MHendricks
force-pushed
the
mikeh/site_cache
branch
from
1b4b474 to
37dfdce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The more distros and configs you have the slower hab becomes. Especially if you have a lot of them on the network. The biggest bottleneck is the globs on windows. There is also likely some slowness for json parsing every file individually.
This saves a cache of the configs and distros on a per-site basis. I the cache exists it is used instead of scanning the file system.
Checklist
Types of Changes
Proposed Changes