Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better error reporting if setuptools-scm is not installed #9

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

MHendricks
Copy link
Member

Restore hard requirement of setuptools-scm, hab was designed to require it.

Checklist

  • I have read the CONTRIBUTING.md document
  • I formatted my changes with black
  • I linted my changes with flake8
  • I have added documentation regarding my changes where necessary
  • Any pre-existing tests continue to pass
  • Additional tests were made covering my changes

Types of Changes

  • Bugfix (change that fixes an issue)
  • New Feature (change that adds functionality)
  • Documentation Update (if none of the other choices apply)

Proposed Changes

Re-adds setuptools_scm as a hard pip requirement. Adds better error reporting if setuptools_scm is not installed, and improves test coverage over distro_version.py.

Restore hard requirement of setuptools-scm, hab was designed to require it.
@MHendricks MHendricks merged commit 53aa9d9 into blurstudio:main Aug 15, 2022
@MHendricks MHendricks deleted the setuptools-scm branch August 15, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant