Skip to content

Commit

Permalink
[net processing] Add Orphanage empty consistency check
Browse files Browse the repository at this point in the history
When removing the final peer, assert that m_tx_orphanage is empty.
  • Loading branch information
jnewbery committed Jul 20, 2021
1 parent 201c5e4 commit 9190b01
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/net_processing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1194,6 +1194,7 @@ void PeerManagerImpl::FinalizeNode(const CNode& node)
assert(m_outbound_peers_with_protect_from_disconnect == 0);
assert(m_wtxid_relay_peers == 0);
assert(m_txrequest.Size() == 0);
assert(m_orphanage.Size() == 0);
}
} // cs_main
if (node.fSuccessfullyConnected && misbehavior == 0 &&
Expand Down
7 changes: 7 additions & 0 deletions src/txorphanage.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,13 @@ class TxOrphanage {
* (ie orphans that may have found their final missing parent, and so should be reconsidered for the mempool) */
void AddChildrenToWorkSet(const CTransaction& tx, std::set<uint256>& orphan_work_set) const EXCLUSIVE_LOCKS_REQUIRED(g_cs_orphans);

/** Return how many entries exist in the orphange */
size_t Size() LOCKS_EXCLUDED(::g_cs_orphans)
{
LOCK(::g_cs_orphans);
return m_orphans.size();
}

protected:
struct OrphanTx {
CTransactionRef tx;
Expand Down

0 comments on commit 9190b01

Please sign in to comment.