Skip to content

Commit

Permalink
Prevent make distclean removing 0 sized file
Browse files Browse the repository at this point in the history
__init__.py used by Python packages typically has nothing in it
including contrib/pyzfs/libzfs_core/test/__init__.py, however this
causes `make distclean` to delete the file.

This is the only file with size 0, and it seems reasonable to have
a comment to avoid being deleted, rather than trying to modify
distclean behavior.

 # find . -size 0
 ./contrib/pyzfs/libzfs_core/test/__init__.py
 # ./autogen.sh ; ./configure ; make -j8
 # make distclean
 # ls contrib/pyzfs/libzfs_core/test/__init__.py
 ls: cannot access 'contrib/pyzfs/libzfs_core/test/__init__.py':
     No such file or directory
 # git diff
 diff --git a/contrib/pyzfs/libzfs_core/test/__init__.py
     b/contrib/pyzfs/libzfs_core/test/__init__.py
 deleted file mode 100644

Reviewed-by: Brian Behlendorf <[email protected]>
Signed-off-by: Tomohiro Kusumi <[email protected]>
Closes openzfs#7505
  • Loading branch information
kusumi authored and behlendorf committed May 7, 2018
1 parent fb0da71 commit e1245d8
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions contrib/pyzfs/libzfs_core/test/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
# `make distclean` deletes files with size 0. This comment is to avoid that.

0 comments on commit e1245d8

Please sign in to comment.