[AIRFLOW-771] Make S3 logs append instead of clobber

Closes apache#2003 from aoen/ddavydov/make_airflow_logs_append_only
bo01ean · Jan 20, 2017 · 5933fca · 5933fca
1 parent a3927e2
commit 5933fca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/airflow/bin/cli.py b/airflow/bin/cli.py
@@ -494,10 +494,7 @@ def run(args, dag=None):
             logging_utils.S3Log().write(log, remote_log_location)
         # GCS
         elif remote_base.startswith('gs:/'):
-            logging_utils.GCSLog().write(
-                log,
-                remote_log_location,
-                append=True)
+            logging_utils.GCSLog().write(log, remote_log_location)
         # Other
         elif remote_base and remote_base != 'None':
             logging.error(

diff --git a/airflow/utils/logging.py b/airflow/utils/logging.py
@@ -81,7 +81,7 @@ def read(self, remote_log_location, return_error=False):
         logging.error(err)
         return err if return_error else ''
 
-    def write(self, log, remote_log_location, append=False):
+    def write(self, log, remote_log_location, append=True):
         """
         Writes the log to the remote_log_location. Fails silently if no hook
         was created.
@@ -159,7 +159,7 @@ def read(self, remote_log_location, return_error=False):
         logging.error(err)
         return err if return_error else ''
 
-    def write(self, log, remote_log_location, append=False):
+    def write(self, log, remote_log_location, append=True):
         """
         Writes the log to the remote_log_location. Fails silently if no hook
         was created.