Skip to content

Commit

Permalink
changed according to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
wochinge committed Oct 23, 2018
1 parent ccc89d1 commit 6776702
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 16 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,16 @@ Added
- show visualization of conversation while doing interactive learning
- option for end-to-end evaluation of Rasa Core and NLU examples in
``evaluate.py`` script
- docker-compose file to start a rasa core server together with nlu, an action server, and duckling

Changed
-------
- improved response format for ``/predict`` endpoint
- all error messages from the server are now in json format
- ``agent.log_message`` now returns a tracker instead of the trackers state
- the core container does not load the nlu model by default anymore.
Instead it can be connected to a nlu server.


Removed
-------
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ COPY . .

RUN pip install -e . --no-cache-dir

VOLUME ["/app/dialogue", "/app/out"]
VOLUME ["/app/dialogue", "/app/endpoints", "/app/out"]

EXPOSE 5005

Expand Down
8 changes: 3 additions & 5 deletions docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ services:
- "5005:5005"
volumes:
- "./rasa-app-data/dialogue:/app/dialogue"
environment:
- RASA_ACTION_URL=http://action_server:5055/webhook
- RASA_NLU_HOST=http://rasanlu:5000
- "./rasa-app-data/endpoints:/app/endpoints"
command:
- start
- -d
Expand All @@ -20,7 +18,7 @@ services:
- -u
- current/nlu
- --endpoints
- endpoints.yml
- endpoints/endpoints.yml
action_server:
image: rasa/rasa_core_sdk:latest
networks: ['rasa-network']
Expand All @@ -42,4 +40,4 @@ services:
ports:
- "8000:8000"

networks: {rasa-network: {}}
networks: {rasa-network: {}}
10 changes: 0 additions & 10 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@ function print_help {
echo " run - Run an arbitrary command inside the container"
}

if [[ -v RASA_ACTION_URL ]]; then
echo "action_endpoint:" > endpoints.yml
echo " url: '${RASA_ACTION_URL}'" >> endpoints.yml
fi

if [[ -v RASA_NLU_HOST ]]; then
echo "nlu:" >> endpoints.yml
echo " url: '${RASA_NLU_HOST}'" >> endpoints.yml
fi

case ${1} in
start)
exec python -m rasa_core.run --enable_api "${@:2}"
Expand Down

0 comments on commit 6776702

Please sign in to comment.