fix: update process_attestation for deneb (ReamLabs#113)

* fix: update process_attestation for deneb * chore: sort with operation_name
bomanaps · Feb 21, 2025 · b7b4d92 · b7b4d92
1 parent 26578a3
commit b7b4d92
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/crates/common/consensus/src/deneb/beacon_state.rs b/crates/common/consensus/src/deneb/beacon_state.rs
@@ -514,12 +514,12 @@ impl BeaconState {
     }
 
     pub fn add_flag(flags: u8, flag_index: u8) -> u8 {
-        let flag = 2 << flag_index;
+        let flag = 1 << flag_index;
         flags | flag
     }
 
     pub fn has_flag(flags: u8, flag_index: u8) -> bool {
-        let flag = 2 << flag_index;
+        let flag = 1 << flag_index;
         flags & flag == flag
     }
 
@@ -647,7 +647,7 @@ impl BeaconState {
         if is_matching_source && inclusion_delay <= (SLOTS_PER_EPOCH as f64).sqrt() as u64 {
             participation_flag_indices.push(TIMELY_SOURCE_FLAG_INDEX);
         }
-        if is_matching_target && inclusion_delay <= SLOTS_PER_EPOCH {
+        if is_matching_target {
             participation_flag_indices.push(TIMELY_TARGET_FLAG_INDEX);
         }
         if is_matching_head && inclusion_delay == MIN_ATTESTATION_INCLUSION_DELAY {

diff --git a/testing/ef-tests/tests/tests.rs b/testing/ef-tests/tests/tests.rs
@@ -65,6 +65,13 @@ test_consensus_type!(VoluntaryExit);
 test_consensus_type!(Withdrawal);
 
 // Testing operations for block processing
+test_operation!(attestation, Attestation, "attestation", process_attestation);
+test_operation!(
+    bls_to_execution_change,
+    SignedBLSToExecutionChange,
+    "address_change",
+    process_bls_to_execution_change
+);
 test_operation!(deposit, Deposit, "deposit", process_deposit);
 test_operation!(
     voluntary_exit,
@@ -78,12 +85,6 @@ test_operation!(
     "execution_payload",
     process_withdrawals
 );
-test_operation!(
-    bls_to_execution_change,
-    SignedBLSToExecutionChange,
-    "address_change",
-    process_bls_to_execution_change
-);
 
 // Testing shuffling
 test_shuffling!();