[dashboard] remove loading spinner in missing chart holder (apache#9140)

bootslee · Feb 14, 2020 · b0110a7 · b0110a7
1 parent f993bdc
commit b0110a7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/superset-frontend/spec/javascripts/dashboard/components/MissingChart_spec.jsx b/superset-frontend/spec/javascripts/dashboard/components/MissingChart_spec.jsx
@@ -19,7 +19,6 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 
-import Loading from '../../../../src/components/Loading';
 import MissingChart from '../../../../src/dashboard/components/MissingChart';
 
 describe('MissingChart', () => {
@@ -37,9 +36,4 @@ describe('MissingChart', () => {
     const wrapper = setup();
     expect(wrapper.find('.missing-chart-body')).toHaveLength(1);
   });
-
-  it('renders a Loading', () => {
-    const wrapper = setup();
-    expect(wrapper.find(Loading)).toHaveLength(1);
-  });
 });
diff --git a/superset-frontend/src/dashboard/components/MissingChart.jsx b/superset-frontend/src/dashboard/components/MissingChart.jsx
@@ -20,18 +20,13 @@ import PropTypes from 'prop-types';
 import React from 'react';
 import { t } from '@superset-ui/translation';
 
-import Loading from '../../components/Loading';
-
 const propTypes = {
   height: PropTypes.number.isRequired,
 };
 
 export default function MissingChart({ height }) {
   return (
     <div className="missing-chart-container" style={{ height: height + 20 }}>
-      <div className="loading-container">
-        <Loading />
-      </div>
       <div className="missing-chart-body">
         {t(
           'There is no chart definition associated with this component, could it have been deleted?',

diff --git a/superset-frontend/src/dashboard/stylesheets/components/chart.less b/superset-frontend/src/dashboard/stylesheets/components/chart.less
@@ -29,14 +29,12 @@
     flex-direction: column;
     align-items: center;
     overflow-y: auto;
+    justify-content: center;
 
     .missing-chart-body {
       font-size: @font-size-s;
-    }
-
-    .loading-container {
       position: relative;
-      height: 40%;
+      display: flex;
     }
   }