Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax unit test thresholds to fix 32bit issues #1625

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

jlblancoc
Copy link
Member

This will solve part of the pending issues in #1605 :

(cc @dkogan )

  • i386 fails one of the first set of tests: it looks like it just barely misses some thresholds, so it's probably not a failure. But since it failed something in the first set, we don't know if any of the second set of tests would have failed

@varunagrawal
Copy link
Collaborator

Would it be wise to set the thresholds based on preprocessor flags indicating the architecture type?

If we have the flag GTSAM_ARCH_TYPE, we could check at compile time and set this accordingly. Just a suggestion.

Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlblancoc Before merging could you add a constexpr if check on the current architecture?

@jlblancoc jlblancoc force-pushed the fix/tests-i686-thresholds branch from e1f75f2 to 1f93e90 Compare September 7, 2023 22:21
Use a conditional threshold depending on architecture
@jlblancoc jlblancoc force-pushed the fix/tests-i686-thresholds branch from 1f93e90 to d2e4dff Compare September 7, 2023 22:23
@jlblancoc
Copy link
Member Author

Take a look at the patch now.

I checked that i686-linux-gnu-g++ defines both preprocessor symbols. i386 is actually obsolete and only i686 will remain for a few years as a main Debian arch, but I added both just in case.

@varunagrawal The idea of a cmake-level architecture variable that maps into a macro seems good (I think that is what your proposal is about?), but if we are using it just here, maybe just the macros are the minimal solution...

@jlblancoc
Copy link
Member Author

One CI task failed, but I think it's not related to this PR's changes... I have re-launched it.

@varunagrawal varunagrawal merged commit 271b9f3 into develop Sep 8, 2023
@varunagrawal varunagrawal deleted the fix/tests-i686-thresholds branch September 8, 2023 10:38
@varunagrawal
Copy link
Collaborator

Awesome! Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants