Skip to content

Commit

Permalink
Add qtsqlglobal.h and qtsqlglobal_p.h
Browse files Browse the repository at this point in the history
The new modular configuration system requires one global
header per module, that is included by all other files in
this module.

QtSql already had such a header, but its name (qsql.h) was
not in line with what's being used in all other modules. So
add a qtsqlglobal.h header, deprecate qsql.h and turn it
into a a forwarding header to that new global header file.

Change-Id: Ibaeb95b008cf08ba062cbfe8a3f4d3bf79294390
Reviewed-by: Oswald Buddenhagen <[email protected]>
  • Loading branch information
laknoll committed Jul 3, 2016
1 parent 8af681c commit 7331d22
Show file tree
Hide file tree
Showing 23 changed files with 85 additions and 11 deletions.
4 changes: 3 additions & 1 deletion src/sql/kernel/kernel.pri
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
HEADERS += kernel/qsql.h \
HEADERS += kernel/qtsqlglobal.h \
kernel/qtsqlglobal_p.h \
kernel/qsql.h \
kernel/qsqlquery.h \
kernel/qsqldatabase.h \
kernel/qsqlfield.h \
Expand Down
1 change: 1 addition & 0 deletions src/sql/kernel/qsqlcachedresult_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include "QtSql/qsqlresult.h"
#include "QtSql/private/qsqlresult_p.h"

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqldatabase.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
#ifndef QSQLDATABASE_H
#define QSQLDATABASE_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qstring.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqldriver.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
#ifndef QSQLDRIVER_H
#define QSQLDRIVER_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qobject.h>
#include <QtCore/qstring.h>
#include <QtCore/qstringlist.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
1 change: 1 addition & 0 deletions src/sql/kernel/qsqldriver_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include "private/qobject_p.h"
#include "qsqldriver.h"
#include "qsqlerror.h"
Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqldriverplugin.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
#ifndef QSQLDRIVERPLUGIN_H
#define QSQLDRIVERPLUGIN_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qplugin.h>
#include <QtCore/qfactoryinterface.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqlerror.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
#ifndef QSQLERROR_H
#define QSQLERROR_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qstring.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqlfield.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
#ifndef QSQLFIELD_H
#define QSQLFIELD_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qvariant.h>
#include <QtCore/qstring.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
1 change: 1 addition & 0 deletions src/sql/kernel/qsqlindex.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#ifndef QSQLINDEX_H
#define QSQLINDEX_H

#include <QtSql/qtsqlglobal.h>
#include <QtSql/qsqlrecord.h>
#include <QtCore/qstring.h>
#include <QtCore/qvector.h>
Expand Down
1 change: 1 addition & 0 deletions src/sql/kernel/qsqlnulldriver_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include "QtCore/qvariant.h"
#include "QtSql/qsqldriver.h"
#include "QtSql/qsqlerror.h"
Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqlquery.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
#ifndef QSQLQUERY_H
#define QSQLQUERY_H

#include <QtSql/qsql.h>
#include <QtSql/qtsqlglobal.h>
#include <QtSql/qsqldatabase.h>
#include <QtCore/qstring.h>

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqlrecord.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
#ifndef QSQLRECORD_H
#define QSQLRECORD_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qstring.h>
#include <QtSql/qsql.h>

QT_BEGIN_NAMESPACE

Expand Down
2 changes: 1 addition & 1 deletion src/sql/kernel/qsqlresult.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,9 @@
#ifndef QSQLRESULT_H
#define QSQLRESULT_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qvariant.h>
#include <QtCore/qvector.h>
#include <QtSql/qsql.h>

// for testing:
class tst_QSqlQuery;
Expand Down
1 change: 1 addition & 0 deletions src/sql/kernel/qsqlresult_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include <QtCore/qpointer.h>
#include "qsqlerror.h"
#include "qsqlresult.h"
Expand Down
4 changes: 2 additions & 2 deletions src/sql/kernel/qsql.h → src/sql/kernel/qtsqlglobal.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
**
****************************************************************************/

#ifndef QSQL_H
#define QSQL_H
#ifndef QTSQLGLOBAL_H
#define QTSQLGLOBAL_H

#include <QtCore/qglobal.h>

Expand Down
57 changes: 57 additions & 0 deletions src/sql/kernel/qtsqlglobal_p.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
/****************************************************************************
**
** Copyright (C) 2016 The Qt Company Ltd.
** Contact: https://www.qt.io/licensing/
**
** This file is part of the QtSql module of the Qt Toolkit.
**
** $QT_BEGIN_LICENSE:LGPL$
** Commercial License Usage
** Licensees holding valid commercial Qt licenses may use this file in
** accordance with the commercial license agreement provided with the
** Software or, alternatively, in accordance with the terms contained in
** a written agreement between you and The Qt Company. For licensing terms
** and conditions see https://www.qt.io/terms-conditions. For further
** information use the contact form at https://www.qt.io/contact-us.
**
** GNU Lesser General Public License Usage
** Alternatively, this file may be used under the terms of the GNU Lesser
** General Public License version 3 as published by the Free Software
** Foundation and appearing in the file LICENSE.LGPL3 included in the
** packaging of this file. Please review the following information to
** ensure the GNU Lesser General Public License version 3 requirements
** will be met: https://www.gnu.org/licenses/lgpl-3.0.html.
**
** GNU General Public License Usage
** Alternatively, this file may be used under the terms of the GNU
** General Public License version 2.0 or (at your option) the GNU General
** Public license version 3 or any later version approved by the KDE Free
** Qt Foundation. The licenses are as published by the Free Software
** Foundation and appearing in the file LICENSE.GPL2 and LICENSE.GPL3
** included in the packaging of this file. Please review the following
** information to ensure the GNU General Public License requirements will
** be met: https://www.gnu.org/licenses/gpl-2.0.html and
** https://www.gnu.org/licenses/gpl-3.0.html.
**
** $QT_END_LICENSE$
**
****************************************************************************/

#ifndef QTSQLGLOBAL_P_H
#define QTSQLGLOBAL_P_H

//
// W A R N I N G
// -------------
//
// This file is not part of the Qt API. It exists purely as an
// implementation detail. This header file may change from version to
// version without notice, or even be removed.
//
// We mean it.
//

#include <QtSql/qtsqlglobal.h>
#include <QtCore/private/qglobal_p.h>

#endif // QTSQLGLOBAL_P_H
1 change: 1 addition & 0 deletions src/sql/models/qsqlquerymodel.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#ifndef QSQLQUERYMODEL_H
#define QSQLQUERYMODEL_H

#include <QtSql/qtsqlglobal.h>
#include <QtCore/qabstractitemmodel.h>
#include <QtSql/qsqldatabase.h>

Expand Down
1 change: 1 addition & 0 deletions src/sql/models/qsqlquerymodel_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include "private/qabstractitemmodel_p.h"
#include "QtSql/qsqlerror.h"
#include "QtSql/qsqlquery.h"
Expand Down
2 changes: 2 additions & 0 deletions src/sql/models/qsqlrelationaldelegate.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@
#ifndef QSQLRELATIONALDELEGATE_H
#define QSQLRELATIONALDELEGATE_H

#include <QtSql/qtsqlglobal.h>

#ifdef QT_WIDGETS_LIB

#include <QtWidgets/qitemdelegate.h>
Expand Down
1 change: 1 addition & 0 deletions src/sql/models/qsqlrelationaltablemodel.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#ifndef QSQLRELATIONALTABLEMODEL_H
#define QSQLRELATIONALTABLEMODEL_H

#include <QtSql/qtsqlglobal.h>
#include <QtSql/qsqltablemodel.h>

QT_BEGIN_NAMESPACE
Expand Down
1 change: 1 addition & 0 deletions src/sql/models/qsqltablemodel.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
#ifndef QSQLTABLEMODEL_H
#define QSQLTABLEMODEL_H

#include <QtSql/qtsqlglobal.h>
#include <QtSql/qsqldatabase.h>
#include <QtSql/qsqlquerymodel.h>

Expand Down
1 change: 1 addition & 0 deletions src/sql/models/qsqltablemodel_p.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
// We mean it.
//

#include <QtSql/private/qtsqlglobal_p.h>
#include "private/qsqlquerymodel_p.h"
#include "QtSql/qsqlindex.h"
#include "QtCore/qmap.h"
Expand Down
3 changes: 3 additions & 0 deletions sync.profile
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,9 @@
"QtGui" => {
"QGenericPlugin" => "QtGui/QGenericPlugin",
"QGenericPluginFactory" => "QtGui/QGenericPluginFactory"
},
"QtSql" => {
"qsql.h" => "QtSql/qtsqlglobal.h"
}
);

Expand Down

0 comments on commit 7331d22

Please sign in to comment.