qmake/vcxproj: Fix handling of extra compiler outputs

In commit 68866b1 we introduced a bug: At a point where the first output of an extra compiler is extracted, we try to evaluate the first output as qmake variable. This is as nonsensical as it sounds and leads to malformed extra compiler output in vcxproj files. Task-number: QTBUG-87601 Change-Id: Ib9aaf8a6eed8c69243f364554325c240d0bfc7f4 Reviewed-by: Miguel Costa <[email protected]> Reviewed-by: Oliver Wolff <[email protected]> (cherry picked from commit 93ac7b9) Reviewed-by: Qt Cherry-pick Bot <[email protected]>
boris-fx · Nov 2, 2020 · 84f5db7 · 84f5db7
1 parent 0a6aa1d
commit 84f5db7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/qmake/generators/win32/msvc_vcproj.cpp b/qmake/generators/win32/msvc_vcproj.cpp
@@ -1568,7 +1568,7 @@ void VcprojGenerator::initExtraCompilerOutputs()
 
             QString tmp_out;
             if (!outputs.isEmpty())
-                tmp_out = project->first(outputs.first().toKey()).toQString();
+                tmp_out = outputs.first().toQString();
             if (project->values(ProKey(*it + ".CONFIG")).indexOf("combine") != -1) {
                 // Combined output, only one file result
                 extraCompile.addFile(Option::fixPathToTargetOS(