refactor: filter fragments potentially evicted from buffer on BufferF…

…lushed
born2c0de · Feb 20, 2018 · faf1473 · faf1473
1 parent 2042289
commit faf1473
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/dist/hls.js.map b/dist/hls.js.map
diff --git a/src/controller/stream-controller.js b/src/controller/stream-controller.js
@@ -1528,8 +1528,8 @@ _checkBuffer() {
       use mediaBuffered instead of media (so that we will check against video.buffered ranges in case of alt audio track)
     */
     const media = this.mediaBuffer ? this.mediaBuffer : this.media;
-
-    this._bufferedFrags = this._bufferedFrags.filter(frag => {return BufferHelper.isBuffered(media,(frag.startPTS + frag.endPTS) / 2);});
+    // filter fragments potentially evicted from buffer. this is to avoid memleak on live streams
+    this.fragmentTracker.detectEvictedFragments(Fragment.ElementaryStreamTypes.VIDEO, media.buffered);
 
     // move to IDLE once flush complete. this should trigger new fragment loading
     this.state = State.IDLE;

diff --git a/src/helper/fragment-tracker.js b/src/helper/fragment-tracker.js
@@ -67,7 +67,7 @@ export class FragmentTracker extends EventHandler {
    * The browser will unload parts of the buffer to free up memory for new buffer data
    * Fragments will need to be reloaded when the buffer is freed up, removing partial fragments will allow them to reload(since there might be parts that are still playable)
    * @param {String} elementaryStream The elementaryStream of media this is (eg. video/audio)
-   * @param {Object} timeRange TimeRange object from a sourceBuffer
+   * @param {TimeRanges} timeRange TimeRange object from a sourceBuffer
    */
   detectEvictedFragments(elementaryStream, timeRange) {
     let fragmentTimes, time;