SAK-27494 prevent samigo from creating duplicate gradebook items (sam…

…e name) (sakaiproject#3986)
bot2012 · Mar 2, 2017 · 06cd10e · 06cd10e
1 parent 3bd6b31
commit 06cd10e
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/...src/java/org/sakaiproject/component/gradebook/GradebookExternalAssessmentServiceImpl.java b/...src/java/org/sakaiproject/component/gradebook/GradebookExternalAssessmentServiceImpl.java
@@ -160,7 +160,7 @@ public void destroy() {
      */
     public static final String UPDATE_SAME_SCORE_PROP = "gradebook.externalAssessments.updateSameScore";
 
-	public void addExternalAssessment(final String gradebookUid, final String externalId, final String externalUrl,
+	public synchronized void addExternalAssessment(final String gradebookUid, final String externalId, final String externalUrl,
 			final String title, final double points, final Date dueDate, final String externalServiceDescription)
             throws ConflictingAssignmentNameException, ConflictingExternalIdException, GradebookNotFoundException {
 
@@ -684,7 +684,7 @@ public void addExternalAssessment(final String gradebookUid, final String extern
 		addExternalAssessment(gradebookUid, externalId, externalUrl, title, points, dueDate, externalServiceDescription, ungraded, null);
 	}
 
-	public void addExternalAssessment(final String gradebookUid, final String externalId, final String externalUrl, final String title, final Double points, 
+	public synchronized void addExternalAssessment(final String gradebookUid, final String externalId, final String externalUrl, final String title, final Double points,
 		final Date dueDate, final String externalServiceDescription, final Boolean ungraded, final Long categoryId) 
 		throws GradebookNotFoundException, ConflictingAssignmentNameException, ConflictingExternalIdException, AssignmentHasIllegalPointsException
 	{