Set data_converter for activity types #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the data converter was being set in the swf_options attached to the function and not in the ActivityType where it is looked for. This meant that the default data converter was always used.
Current coverage is 0.00% (diff: 0.00%)@@ master #4 diff @@
====================================
Files 72 72
Lines 3469 3470 +1
Methods 0 0
Messages 0 0
Branches 484 485 +1
====================================
Hits 0 0
- Misses 3469 3470 +1
Partials 0 0
|
|
Awesome stuff! Thanks for the pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the data converter was being set in the swf_options
attached to the function and not in the ActivityType where it is looked
for. This meant that the default data converter was always used.