Skip to content

Commit

Permalink
Merge pull request GoogleCloudPlatform#2 from bharathkkb/bugfixes
Browse files Browse the repository at this point in the history
Minor bugs, add codeowners
  • Loading branch information
r4hulgupta authored Mar 3, 2020
2 parents a45cde4 + 2efc161 commit dc39c8d
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
1 change: 1 addition & 0 deletions CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@bharathkkb @r4hulgupta
2 changes: 1 addition & 1 deletion example-pipelines/example-create/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pipeline {
steps {
container('terraform') {
sh '''cd example-pipelines/example-create
terraform plan -var project_id=$PROJECT_ID --out=test.out'''
terraform plan --out=test.out'''
}
}
}
Expand Down
10 changes: 0 additions & 10 deletions jenkins-gke/tf-gke/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,6 @@ variable "tfstate_gcs_backend" {
default = "TFSTATE_GCS_BACKEND"
}

variable "restart_policy" {
description = "The desired Docker restart policy for the deployed image"
default = "Always"
}

variable "region" {
description = "The GCP region to deploy instances into"
default = "us-east4"
Expand Down Expand Up @@ -61,11 +56,6 @@ variable "subnet_name" {
default = "jenkins-subnet"
}

variable "jenkins_project_name" {
description = "Name for jenkins project"
default = "jenkins-gke"
}

variable "jenkins_k8s_config" {
description = "Name for the k8s secret required to configure k8s executers on Jenkins"
default = "jenkins-k8s-config"
Expand Down

0 comments on commit dc39c8d

Please sign in to comment.