[#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctions into hook.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
hyejj19
approved these changes
Dec 7, 2024
There was a problem hiding this comment.
음... 여러개를 export 할 가능성을 생각했었는데 딱히 없을 것 같네요ㅋㅋ 수정할게요!
Comment on lines
+4
to
+9
| const [isProcessing, setIsProcessing] = useState(false); | ||
|
|
||
| const executeApiCall = async (apiCallFunction: () => Promise<void>) => { | ||
| if (isProcessing) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
state 보다는 ref 가 좋지 않을까 하는데 어떻게 생각하세요?
렌더링 영향 안받고 화면에 표시되는 데이터는 아니니깐..
There was a problem hiding this comment.
제가 현재 사용하는 page에서 {isProcessing && } 형태로 해당 값을 사용하고 있어서 ref를 사용하면 값이 변경되어도 리렌더링이 발생하지 않아 Loading 컴포넌트가 제때 나타나거나 사라지지 않는 오류가 있지 않을까 하는 우려가 있을 것 같아서요!
sarumi-k
changed the title
|
sarumi-k
added a commit
that referenced
this pull request
Dec 7, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name.
sarumi-k
added a commit
that referenced
this pull request
Dec 7, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug.
hyejj19
added a commit
that referenced
this pull request
Dec 8, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug. * [#185] 플러터 채널링 수정 - device 정보 전송 (#197) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Add] log to flutter method * [Chore] display login status for temp * [Modify] replace condition * [Modify] comment out * [Modify] log message * [Modify] display message * [Modify] isInApp -> ref * [Modify] to save isInApp in localStorage * [Modify] Stringify * [Modify] send Error to flutter * [Fix] Invalid destructure code * [Modify] data structure of deviceInfo * [Fix] delete response.json for fetchWithAuth response * [Modify] save DeviceInfo in local Storage * [Modify] log message * [Delete] display data --------- Co-authored-by: sarumi-k <[email protected]> Co-authored-by: sareum <[email protected]>
sarumi-k
added a commit
that referenced
this pull request
Dec 15, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug. * [#185] 플러터 채널링 수정 - device 정보 전송 (#197) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Add] log to flutter method * [Chore] display login status for temp * [Modify] replace condition * [Modify] comment out * [Modify] log message * [Modify] display message * [Modify] isInApp -> ref * [Modify] to save isInApp in localStorage * [Modify] Stringify * [Modify] send Error to flutter * [Fix] Invalid destructure code * [Modify] data structure of deviceInfo * [Fix] delete response.json for fetchWithAuth response * [Modify] save DeviceInfo in local Storage * [Modify] log message * [Delete] display data * [#196] Review 디자인, 로직 변경 및 오류 수정 (#199) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. --------- Co-authored-by: Hyejung Park <[email protected]> --------- Co-authored-by: Hyejung Park <[email protected]>
sarumi-k
added a commit
that referenced
this pull request
Dec 15, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug. * [#185] 플러터 채널링 수정 - device 정보 전송 (#197) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Add] log to flutter method * [Chore] display login status for temp * [Modify] replace condition * [Modify] comment out * [Modify] log message * [Modify] display message * [Modify] isInApp -> ref * [Modify] to save isInApp in localStorage * [Modify] Stringify * [Modify] send Error to flutter * [Fix] Invalid destructure code * [Modify] data structure of deviceInfo * [Fix] delete response.json for fetchWithAuth response * [Modify] save DeviceInfo in local Storage * [Modify] log message * [Delete] display data * [#196] Review 디자인, 로직 변경 및 오류 수정 (#199) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. --------- Co-authored-by: Hyejung Park <[email protected]> * 모바일 화면을 위한 Header, bottom 사이즈 변경 (#201) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. * [Style] Change header, bottom size. --------- Co-authored-by: Hyejung Park <[email protected]> --------- Co-authored-by: Hyejung Park <[email protected]>
hyejj19
added a commit
that referenced
this pull request
Dec 24, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug. * [#185] 플러터 채널링 수정 - device 정보 전송 (#197) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Add] log to flutter method * [Chore] display login status for temp * [Modify] replace condition * [Modify] comment out * [Modify] log message * [Modify] display message * [Modify] isInApp -> ref * [Modify] to save isInApp in localStorage * [Modify] Stringify * [Modify] send Error to flutter * [Fix] Invalid destructure code * [Modify] data structure of deviceInfo * [Fix] delete response.json for fetchWithAuth response * [Modify] save DeviceInfo in local Storage * [Modify] log message * [Delete] display data * [#196] Review 디자인, 로직 변경 및 오류 수정 (#199) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. --------- Co-authored-by: Hyejung Park <[email protected]> * 모바일 화면을 위한 Header, bottom 사이즈 변경 (#201) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. * [Style] Change header, bottom size. --------- Co-authored-by: Hyejung Park <[email protected]> * [#204] 회원탈퇴/게스트 로그인 api 연동 (#205) * feat: delete account api * fix: sidbar select area * add: guest login api - 404 not found * fix: comment out (checkIsApp...) - 불편해도 조금만 참으세요 ㅠㅠ 죄송합니다 ㅠㅠ --------- Co-authored-by: sarumi-k <[email protected]> Co-authored-by: sareum <[email protected]>
sarumi-k
added a commit
that referenced
this pull request
Dec 24, 2024
* [#146] Review 개선 및 기능, API 수정 (#186) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [#146] input, textarea 커지는 현상 수정 - 1 (#188) * [Modify] Add condition to allow spaces in tag condition. * [Modify] Prevent screen zoom when clicking on input field. * [Modify] Add scrollbar-hide to horizontal scroll. * [Style] Improve alcohol information styling in review writing. * [Refactor] Separate AlcoholImage component and refactor code. * [Style] Change font size and icon, start size. * [Modify] Added props for width and height to enhance reusability. * [Modify] Change font size and add AlcoholImage component. * [Modify] Updated Alcohol, review types to reflect API changes * [Modify] Updated data to reflect API changes. * [Modify] Updated review details types to reflect API changes * [Style] Change layout, size of Review details. * [Fix] Fix build errors. * [Modify] Add rating param to review post, patch API. * [Modify] Change review price logic. * [Style] Modify weekly hot5 images style. * [Feat] Add logic to check for the presence of a token and whether a token is required. * [Fix] Fix build errors. * [Modify] Updated data to reflect Alcohol API changes. * [Modify] Change font size. * [Modify] Modify viewport settings to prevent text enlargement on click. * [#190] API 응답 처리 전 중복 요청 방지 로직 구현 및 review 리팩토링 (#191) * [Style] Modify header, footer padding to mobile view size. * [Style] Add disabled color to Button. * [Refactor] Change error modal to hook. * [Refactor] Separation of concerns and extraction of frequently used functions into hook. * [Fix] Add logic to prevent duplicate calls until the API response is received. * [Feat] Add loading to search detail page. * [Modify] Change export function name. * [Fix] Fix alcohol details rendering bug. * [#185] 플러터 채널링 수정 - device 정보 전송 (#197) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Add] log to flutter method * [Chore] display login status for temp * [Modify] replace condition * [Modify] comment out * [Modify] log message * [Modify] display message * [Modify] isInApp -> ref * [Modify] to save isInApp in localStorage * [Modify] Stringify * [Modify] send Error to flutter * [Fix] Invalid destructure code * [Modify] data structure of deviceInfo * [Fix] delete response.json for fetchWithAuth response * [Modify] save DeviceInfo in local Storage * [Modify] log message * [Delete] display data * [#196] Review 디자인, 로직 변경 및 오류 수정 (#199) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. --------- Co-authored-by: Hyejung Park <[email protected]> * 모바일 화면을 위한 Header, bottom 사이즈 변경 (#201) * [#185] 플러터 채널링 활성화 - 로그인시 device info 받아와서 서버로 전달 (#195) * [Delete] duplicated types.d.ts * [Add] flutter message handler logic * [Modify] to display flutter message in login page for test * [Fix] Change window.kakao reference to window.Kakao * [Style] add padding top 48px in user page * fix: comment out * [Modify] register getDeviceToken as global function of window object * modify: getDeviceToken function * [Add] devcieToken handler as window global function * [Modify] global function registration * [Chore] comment out * [Style] delete padding * [Chore] add comment * [Modify] apply stringify method * [Add] Apply sendDeviceInfo Api Call function - 유저가 로그인을 완료하고 로그인 페이지로 이동했을 때 해당 함수로 디바이스 정보를 보내도록 api 호출 추가 * [Add] flutter handler to check is web view * [Delete] window reference in flutter Util file * [Modify] flutter message * [Modify] useEffect to check window.isInApp as deps * [Delete] isInApp deps * [Modify] Add optionsContainer component to review form. * [Modify] Apply optionsContainer to priceForm and update logic. * [Modify] Apply optionsContainer to AddressForm and update logic. * [Modify] Apply optionContainer to ImageForm and update logic. * [Modify] Apply optionContainer to TagsForm and update logic. * [Feat] Add HoverTouchBox and apply to tagsForm. * [Refactor] Make the form folder at review. * [Style] Adjust button area ratio. * [Style] Modify height from bottom. * [Fix] Add a condition to exclude the reviews list page from the navbar view. * [Modify] Change SubHeader title size logic. * [Modify] Apply useCallOnce logic to reply api. * [Fix] Modify build errors. * [Modify] modify header padding size and logo files. * [Style] Change header, bottom size. --------- Co-authored-by: Hyejung Park <[email protected]> * [#204] 회원탈퇴/게스트 로그인 api 연동 (#205) * feat: delete account api * fix: sidbar select area * add: guest login api - 404 not found * fix: comment out (checkIsApp...) - 불편해도 조금만 참으세요 ㅠㅠ 죄송합니다 ㅠㅠ * [#194] Review 임시저장 기능 구현 (#203) * [Feat]Add review temporary save logic. * [Style]Change header of home padding top size. * [Feat]Add toast logic to review temporary save. * [Feat]Add logic to prevent saving if the review is not written, even after limit minute. --------- Co-authored-by: Hyejung Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 제목 (Title)
변경 사항 (Changes)
테스트 방법 (Test Procedure)
�Alcohol, Review 관련 페이지에서 확인 가능
참고 사항 (Additional Information)