Fix: NPE in myLoad if cluster isn't yet started #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't, then then MetricsRegistry will continue holding onto old gauges and meters, and when reporters like GraphiteReporter ask the MetricsRegistry for all known metrics, it will get a bunch of orphaned metrics that we never unregistered when the work unit was shutdown. Querying the orphaned meters will just return and report 0 values, which is mostly harmless, but querying the orphaned gauges will ask for things that might no longer exist, which is potentially harmful. Further, the orphaned gauges could hold references to otherwise orphaned objects and cause memory leaks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
myLoadgets a nullcluster.loadMapif we haven't yet connected to the cluster, which throws aNullPointerExceptionwhen we try to.toStringit for the debug logging. I went ahead and mademyLoadoverly robust to null things, just so that it doesn't have to be concerned with whichClusterfields can be null and which can't.This is a simple commit in isolation, but I branched it off of the commits in #10 since it now lives in a different file. Let me know if you'd rather I branch it independently.