some code optimization for ClassGenerator.java and DubboMonitor.java (a…

…pache#5746)
bouxin · Mar 26, 2020 · 7dbe632 · 7dbe632
1 parent 70f7216
commit 7dbe632
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java b/dubbo-common/src/main/java/org/apache/dubbo/common/bytecode/ClassGenerator.java
@@ -101,11 +101,9 @@ private static String modifier(int mod) {
         StringBuilder modifier = new StringBuilder();
         if (Modifier.isPublic(mod)) {
             modifier.append("public");
-        }
-        if (Modifier.isProtected(mod)) {
+        } else if (Modifier.isProtected(mod)) {
             modifier.append("protected");
-        }
-        if (Modifier.isPrivate(mod)) {
+        } else if (Modifier.isPrivate(mod)) {
             modifier.append("private");
         }
 

diff --git a/...itor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java b/...itor/dubbo-monitor-default/src/main/java/org/apache/dubbo/monitor/dubbo/DubboMonitor.java
@@ -63,17 +63,13 @@ public class DubboMonitor implements Monitor {
 
     private final MonitorService monitorService;
 
-    /**
-     * The time interval for timer <b>scheduledExecutorService</b> to send data
-     */
-    private final long monitorInterval;
-
     private final ConcurrentMap<Statistics, AtomicReference<long[]>> statisticsMap = new ConcurrentHashMap<Statistics, AtomicReference<long[]>>();
 
     public DubboMonitor(Invoker<MonitorService> monitorInvoker, MonitorService monitorService) {
         this.monitorInvoker = monitorInvoker;
         this.monitorService = monitorService;
-        this.monitorInterval = monitorInvoker.getUrl().getPositiveParameter("interval", 60000);
+        // The time interval for timer <b>scheduledExecutorService</b> to send data
+        final long monitorInterval = monitorInvoker.getUrl().getPositiveParameter("interval", 60000);
         // collect timer for collecting statistics data
         sendFuture = scheduledExecutorService.scheduleWithFixedDelay(() -> {
             try {