Skip to content

Commit

Permalink
runtime: remove out-of-date comment
Browse files Browse the repository at this point in the history
It used to be the case that repeatedly getting one GC pointer and
enqueuing one GC pointer could cause contention on the work buffers as
each operation passed over the boundary of a work buffer. As of
b6c0934, we use a two buffer cache that prevents this sort of
contention.

Change-Id: I4f1111623f76df9c5493dd9124dec1e0bfaf53b7
Reviewed-on: https://go-review.googlesource.com/18532
Run-TryBot: Austin Clements <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Rick Hudson <[email protected]>
  • Loading branch information
aclements committed Jan 12, 2016
1 parent 352e287 commit 7b1f055
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/runtime/mgcmark.go
Original file line number Diff line number Diff line change
Expand Up @@ -835,12 +835,6 @@ func gcDrain(gcw *gcWork, flags gcDrainFlags) {
// work barrier reached or tryGet failed.
break
}
// If the current wbuf is filled by the scan a new wbuf might be
// returned that could possibly hold only a single object. This
// could result in each iteration draining only a single object
// out of the wbuf passed in + a single object placed
// into an empty wbuf in scanobject so there could be
// a performance hit as we keep fetching fresh wbufs.
scanobject(b, gcw)

// Flush background scan work credit to the global
Expand Down

0 comments on commit 7b1f055

Please sign in to comment.