Skip to content

Commit

Permalink
Avoid false positives from google by storing OpenSSL version as Unicode.
Browse files Browse the repository at this point in the history
Google scan play store apps for the openssl version string which leads
to false positives since we record the version we were compiled against
even though we don't link it directly.

Task-number: QTBUG-46265
Change-Id: Iefd0e0954149c17350d49f57f9f374938124d7b8
Reviewed-by: Olivier Goffart (Woboq GmbH) <[email protected]>
  • Loading branch information
richmoore authored and Jani Heikkinen committed May 25, 2015
1 parent d4a296b commit 7a4f364
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/network/ssl/qsslsocket_openssl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,10 @@ long QSslSocketPrivate::sslLibraryBuildVersionNumber()

QString QSslSocketPrivate::sslLibraryBuildVersionString()
{
return QLatin1String(OPENSSL_VERSION_TEXT);
// Using QStringLiteral to store the version string as unicode and
// avoid false positives from Google searching the playstore for old
// SSL versions. See QTBUG-46265
return QStringLiteral(OPENSSL_VERSION_TEXT);
}

/*!
Expand Down

0 comments on commit 7a4f364

Please sign in to comment.