Skip to content

Commit

Permalink
Instruction selection fix for qemu cross-builds
Browse files Browse the repository at this point in the history
When building for qemu, the target "os" is still set to Linux, so try to
detect qemu by looking at the version field.

Change-Id: I7c66cdb29a47a44d5b8a394977136139fc646155
Reviewed-by: Alexandru Croitor <[email protected]>
  • Loading branch information
tronical committed Apr 29, 2020
1 parent 512be78 commit 9c76047
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 12 deletions.
22 changes: 16 additions & 6 deletions coin/instructions/coin_module_build_template_v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,23 @@ instructions:
- !include "{{qt/qtbase}}/cmake_module_build_instructions.yaml"
- !include "{{qt/qtbase}}/cmake_build_and_upload_test_artifacts.yaml"
enable_if:
condition: property
property: host.os
equals_property: target.os
condition: and
conditions:
- condition: property
property: host.os
equals_property: target.os
- condition: property
property: target.osVersion
not_equals_value: QEMU
- type: Group
instructions:
- !include "{{qt/qtbase}}/cmake_cross_compilation_module_build_instructions.yaml"
disable_if:
condition: property
property: host.os
equals_property: target.os
condition: and
conditions:
- condition: property
property: host.os
equals_property: target.os
- condition: property
property: target.osVersion
not_equals_value: QEMU
22 changes: 16 additions & 6 deletions coin/instructions/coin_qtbase_build_template_v2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,23 @@ instructions:
- !include "{{qt/qtbase}}/cmake_qtbase_build_instructions.yaml"
- !include "{{qt/qtbase}}/cmake_build_and_upload_test_artifacts.yaml"
enable_if:
condition: property
property: host.os
equals_property: target.os
condition: and
conditions:
- condition: property
property: host.os
equals_property: target.os
- condition: property
property: target.osVersion
not_equals_value: QEMU
- type: Group
instructions:
- !include "{{qt/qtbase}}/cmake_cross_compilation_qtbase_build_instructions.yaml"
disable_if:
condition: property
property: host.os
equals_property: target.os
condition: and
conditions:
- condition: property
property: host.os
equals_property: target.os
- condition: property
property: target.osVersion
not_equals_value: QEMU

0 comments on commit 9c76047

Please sign in to comment.