Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support STARTTLS #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support STARTTLS #6

wants to merge 2 commits into from

Conversation

crazed
Copy link

@crazed crazed commented Mar 9, 2018

In case anyone else goes down the path of SMTP over TLS, this may be useful.

s.sendlinef("220 Ready to start TLS")
if err := s.handleStartTLS(); err != nil {
s.errorf("failed to start tls: %s", err)
s.sendSMTPErrorOrLinef(err, "550 ??? failed")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should not it be s.sendSMTPErrorOrLinef(err, "403 4.7.0 TLS handshake failed")?
  2. Should not it be inside handleStartTLS just to be similar to other usages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants