Use ldiv instead instead of rdiv in naivesub to avoid assuming commut…

…ativity of multiplication
bradparks · Aug 20, 2014 · 2c945d9 · 2c945d9
1 parent 170ed36
commit 2c945d9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/base/linalg/triangular.jl b/base/linalg/triangular.jl
@@ -219,7 +219,7 @@ function naivesub!{T,S,UpLo,IsUnit}(A::Triangular{T,S,UpLo,IsUnit}, b::AbstractV
                 x[j] -= A[j,k] * x[k]
             end
             if !IsUnit
-                x[j]/= A[j,j]==0 ? throw(SingularException(j)) : A[j,j]
+                x[j] = A[j,j]==0 ? throw(SingularException(j)) : A[j,j]\x[j]
             end
         end
     elseif UpLo == :U #do backward substitution
@@ -229,7 +229,7 @@ function naivesub!{T,S,UpLo,IsUnit}(A::Triangular{T,S,UpLo,IsUnit}, b::AbstractV
                 x[j] -= A[j,k] * x[k]
             end
             if !IsUnit
-                x[j]/= A[j,j]==0 ? throw(SingularException(j)) : A[j,j]
+                x[j] = A[j,j]==0 ? throw(SingularException(j)) : A[j,j]\x[j]
             end
         end
     else