Skip to content

Commit

Permalink
t4048: abstract away SHA-1-specific constants
Browse files Browse the repository at this point in the history
Adjust the test so that it computes variables for object IDs instead of
using hard-coded hashes.

Signed-off-by: brian m. carlson <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
bk2204 authored and gitster committed Oct 28, 2019
1 parent cf02be8 commit fa26d5e
Showing 1 changed file with 32 additions and 26 deletions.
58 changes: 32 additions & 26 deletions t/t4048-diff-combined-binary.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,48 +9,51 @@ test_expect_success 'setup binary merge conflict' '
git commit -m one &&
echo twoQ2 | q_to_nul >binary &&
git commit -a -m two &&
two=$(git rev-parse --short HEAD:binary) &&
git checkout -b branch-binary HEAD^ &&
echo threeQ3 | q_to_nul >binary &&
git commit -a -m three &&
three=$(git rev-parse --short HEAD:binary) &&
test_must_fail git merge master &&
echo resolvedQhooray | q_to_nul >binary &&
git commit -a -m resolved
git commit -a -m resolved &&
res=$(git rev-parse --short HEAD:binary)
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --git a/binary b/binary
index 7ea6ded..9563691 100644
index $three..$res 100644
Binary files a/binary and b/binary differ
resolved
diff --git a/binary b/binary
index 6197570..9563691 100644
index $two..$res 100644
Binary files a/binary and b/binary differ
EOF
test_expect_success 'diff -m indicates binary-ness' '
git show --format=%s -m >actual &&
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --combined binary
index 7ea6ded,6197570..9563691
index $three,$two..$res
Binary files differ
EOF
test_expect_success 'diff -c indicates binary-ness' '
git show --format=%s -c >actual &&
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --cc binary
index 7ea6ded,6197570..9563691
index $three,$two..$res
Binary files differ
EOF
test_expect_success 'diff --cc indicates binary-ness' '
Expand All @@ -62,47 +65,50 @@ test_expect_success 'setup non-binary with binary attribute' '
git checkout master &&
test_commit one text &&
test_commit two text &&
two=$(git rev-parse --short HEAD:text) &&
git checkout -b branch-text HEAD^ &&
test_commit three text &&
three=$(git rev-parse --short HEAD:text) &&
test_must_fail git merge master &&
test_commit resolved text &&
res=$(git rev-parse --short HEAD:text) &&
echo text -diff >.gitattributes
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --git a/text b/text
index 2bdf67a..2ab19ae 100644
index $three..$res 100644
Binary files a/text and b/text differ
resolved
diff --git a/text b/text
index f719efd..2ab19ae 100644
index $two..$res 100644
Binary files a/text and b/text differ
EOF
test_expect_success 'diff -m respects binary attribute' '
git show --format=%s -m >actual &&
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --combined text
index 2bdf67a,f719efd..2ab19ae
index $three,$two..$res
Binary files differ
EOF
test_expect_success 'diff -c respects binary attribute' '
git show --format=%s -c >actual &&
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --cc text
index 2bdf67a,f719efd..2ab19ae
index $three,$two..$res
Binary files differ
EOF
test_expect_success 'diff --cc respects binary attribute' '
Expand All @@ -115,11 +121,11 @@ test_expect_success 'setup textconv attribute' '
git config diff.upcase.textconv "tr a-z A-Z <"
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --git a/text b/text
index 2bdf67a..2ab19ae 100644
index $three..$res 100644
--- a/text
+++ b/text
@@ -1 +1 @@
Expand All @@ -128,7 +134,7 @@ index 2bdf67a..2ab19ae 100644
resolved
diff --git a/text b/text
index f719efd..2ab19ae 100644
index $two..$res 100644
--- a/text
+++ b/text
@@ -1 +1 @@
Expand All @@ -140,11 +146,11 @@ test_expect_success 'diff -m respects textconv attribute' '
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --combined text
index 2bdf67a,f719efd..2ab19ae
index $three,$two..$res
--- a/text
+++ b/text
@@@ -1,1 -1,1 +1,1 @@@
Expand All @@ -157,11 +163,11 @@ test_expect_success 'diff -c respects textconv attribute' '
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
resolved
diff --cc text
index 2bdf67a,f719efd..2ab19ae
index $three,$two..$res
--- a/text
+++ b/text
@@@ -1,1 -1,1 +1,1 @@@
Expand All @@ -174,9 +180,9 @@ test_expect_success 'diff --cc respects textconv attribute' '
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
diff --combined text
index 2bdf67a,f719efd..2ab19ae
index $three,$two..$res
--- a/text
+++ b/text
@@@ -1,1 -1,1 +1,1 @@@
Expand All @@ -190,9 +196,9 @@ test_expect_success 'diff-tree plumbing does not respect textconv' '
test_cmp expect actual
'

cat >expect <<'EOF'
cat >expect <<EOF
diff --cc text
index 2bdf67a,f719efd..0000000
index $three,$two..0000000
--- a/text
+++ b/text
@@@ -1,1 -1,1 +1,5 @@@
Expand Down

0 comments on commit fa26d5e

Please sign in to comment.