Skip to content

Commit

Permalink
t7610: don't assume the checked-out commit
Browse files Browse the repository at this point in the history
Always check out the required commit at the beginning of the test so
that a failure in a previous test does not cause the test to work off
of the wrong commit.

This is a step toward making the tests more independent so that if one
test fails it doesn't cause subsequent tests to fail.

Signed-off-by: Richard Hansen <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
  • Loading branch information
rhansen authored and gitster committed Jan 10, 2017
1 parent 61b76d2 commit fef6c06
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions t/t7610-mergetool.sh
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ test_expect_success 'mergetool in subdir' '

test_expect_success 'mergetool on file in parent dir' '
test_when_finished "git reset --hard" &&
git checkout -b test$test_count &&
git checkout -b test$test_count branch1 &&
git submodule update -N &&
(
cd subdir &&
Expand Down Expand Up @@ -218,7 +218,7 @@ test_expect_success 'mergetool skips autoresolved' '

test_expect_success 'mergetool merges all from subdir' '
test_when_finished "git reset --hard" &&
git checkout -b test$test_count &&
git checkout -b test$test_count branch1 &&
test_config rerere.enabled false &&
(
cd subdir &&
Expand Down Expand Up @@ -306,7 +306,7 @@ test_expect_success 'mergetool delete/delete conflict' '

test_expect_success 'mergetool produces no errors when keepBackup is used' '
test_when_finished "git reset --hard HEAD" &&
git checkout -b test$test_count &&
git checkout -b test$test_count move-to-c &&
test_config mergetool.keepBackup true &&
test_must_fail git merge move-to-b &&
: >expect &&
Expand All @@ -317,7 +317,7 @@ test_expect_success 'mergetool produces no errors when keepBackup is used' '

test_expect_success 'mergetool honors tempfile config for deleted files' '
test_when_finished "git reset --hard HEAD" &&
git checkout -b test$test_count &&
git checkout -b test$test_count move-to-c &&
test_config mergetool.keepTemporaries false &&
test_must_fail git merge move-to-b &&
echo d | git mergetool a/a/file.txt &&
Expand All @@ -327,7 +327,7 @@ test_expect_success 'mergetool honors tempfile config for deleted files' '
test_expect_success 'mergetool keeps tempfiles when aborting delete/delete' '
test_when_finished "git reset --hard HEAD" &&
test_when_finished "git clean -fdx" &&
git checkout -b test$test_count &&
git checkout -b test$test_count move-to-c &&
test_config mergetool.keepTemporaries true &&
test_must_fail git merge move-to-b &&
! (echo a; echo n) | git mergetool a/a/file.txt &&
Expand Down Expand Up @@ -664,7 +664,7 @@ test_expect_success 'diff.orderFile configuration is honored' '
'
test_expect_success 'mergetool -Oorder-file is honored' '
test_when_finished "git reset --hard >/dev/null 2>&1" &&
git checkout -b test$test_count &&
git checkout -b test$test_count order-file-side2 &&
test_config diff.orderFile order-file &&
test_config mergetool.myecho.cmd "echo \"\$LOCAL\"" &&
test_config mergetool.myecho.trustExitCode true &&
Expand Down

0 comments on commit fef6c06

Please sign in to comment.