Skip to content

Commit

Permalink
Add an option to specify lfs path
Browse files Browse the repository at this point in the history
Reviewed By: rsunkad

Differential Revision: D24750170

fbshipit-source-id: 5c48ab812b5438a33713315faf83e7a21a3c4eae
  • Loading branch information
bkoray authored and facebook-github-bot committed Nov 6, 2020
1 parent 97c820b commit 8865fac
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
5 changes: 5 additions & 0 deletions build/fbcode_builder/getdeps.py
Original file line number Diff line number Diff line change
Expand Up @@ -983,6 +983,11 @@ def add_common_arg(*args, **kwargs):
action="store_true",
default=False,
)
add_common_arg(
"--lfs-path",
help="Provide a parent directory for lfs when fbsource is unavailable",
default=None,
)

ap = argparse.ArgumentParser(
description="Get and build dependencies and projects", parents=[common_args]
Expand Down
3 changes: 3 additions & 0 deletions build/fbcode_builder/getdeps/buildopts.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ def __init__(
use_shipit=False,
vcvars_path=None,
allow_system_packages=False,
lfs_path=None,
):
"""fbcode_builder_dir - the path to either the in-fbsource fbcode_builder dir,
or for shipit-transformed repos, the build dir that
Expand Down Expand Up @@ -109,6 +110,7 @@ def __init__(
self.host_type = host_type
self.use_shipit = use_shipit
self.allow_system_packages = allow_system_packages
self.lfs_path = lfs_path
if vcvars_path is None and is_windows():

# On Windows, the compiler is not available in the PATH by
Expand Down Expand Up @@ -453,4 +455,5 @@ def setup_build_options(args, host_type=None):
use_shipit=args.use_shipit,
vcvars_path=args.vcvars_path,
allow_system_packages=args.allow_system_packages,
lfs_path=args.lfs_path,
)

0 comments on commit 8865fac

Please sign in to comment.