SAK-40330 Assignment Allow TA with grade to update submission (sakaip…

…roject#9349)

https://jira.sakaiproject.org/browse/SAK-40330

assignment/impl/src/java/org/sakaiproject/assignment/impl/AssignmentServiceImpl.java

@@ -1350,7 +1350,10 @@ public void updateSubmission(AssignmentSubmission submission) throws PermissionE
         Assert.notNull(submission.getId(), "Submission doesn't appear to have been persisted yet");
 
         String reference = AssignmentReferenceReckoner.reckoner().submission(submission).reckon().getReference();
-        if (!allowUpdateSubmission(reference)) {
+        String assignmentReference = AssignmentReferenceReckoner.reckoner().assignment(submission.getAssignment()).reckon().getReference();
+
+        // TODO these permissions checks should coincide with the changes that are being made for the submission
+        if (!(allowUpdateSubmission(reference) || allowGradeSubmission(assignmentReference))) {
             throw new PermissionException(sessionManager.getCurrentSessionUserId(), SECURE_UPDATE_ASSIGNMENT_SUBMISSION, null);
         }
         eventTrackingService.post(eventTrackingService.newEvent(AssignmentConstants.EVENT_UPDATE_ASSIGNMENT_SUBMISSION, reference, true));