Skip to content

Commit

Permalink
ARROW-1419: [GLib] Suppress sign-conversion warnings
Browse files Browse the repository at this point in the history
Apache Arrow C++ uses int as result type for expression that uses
size_t. It causes sign-conversion warning but the coding style is
expected.

Example:

    .../arrow/buffer.h:296:41: warning:
          implicit conversion changes signedness: 'unsigned long' to 'int64_t'
          (aka 'long') [-Wsign-conversion]
      int64_t length() const { return size_ / sizeof(T); }
                               ~~~~~~ ~~~~~~^~~~~~~~~~~

Author: Kouhei Sutou <[email protected]>

Closes apache#999 from kou/glib-suppress-warning-on-clang and squashes the following commits:

397490e [Kouhei Sutou] [GLib] Suppress sign-conversion warnings
  • Loading branch information
kou authored and wesm committed Aug 28, 2017
1 parent 26d4e3f commit 6cd2a17
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions c_glib/configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ AC_PROG_CXX
AX_CXX_COMPILE_STDCXX_11([ext], [mandatory])
LT_INIT

GARROW_CFLAGS="-Wall -Wconversion"
GARROW_CXXFLAGS="-Wall -Wconversion"
GARROW_CFLAGS="-Wall"
GARROW_CXXFLAGS="-Wall"
AC_ARG_ENABLE(debug,
[AS_HELP_STRING([--enable-debug],
[Use debug flags (default=no)])],
Expand Down

0 comments on commit 6cd2a17

Please sign in to comment.