Skip to content

Commit

Permalink
Make clang.excludeArgs accept glob patterns
Browse files Browse the repository at this point in the history
  • Loading branch information
MaskRay committed Mar 5, 2019
1 parent 6c7b868 commit 6a3cff6
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 7 deletions.
5 changes: 2 additions & 3 deletions src/config.hh
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,8 @@ struct Config {
} capabilities;

struct Clang {
// Arguments that should be excluded, e.g. ["-fopenmp", "-Wall"]
//
// e.g. If your project is built by GCC and has an option thag clang does not understand.
// Arguments matching any of these glob patterns will be excluded, e.g.
// ["-fopenmp", "-m*", "-Wall"].
std::vector<std::string> excludeArgs;

// Additional arguments to pass to clang.
Expand Down
21 changes: 17 additions & 4 deletions src/project.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include <clang/Tooling/CompilationDatabase.h>
#include <llvm/ADT/STLExtras.h>
#include <llvm/ADT/StringSet.h>
#include <llvm/Support/GlobPattern.h>
#include <llvm/Support/LineIterator.h>
#include <llvm/Support/Program.h>

Expand Down Expand Up @@ -69,10 +70,22 @@ enum OptionClass {
struct ProjectProcessor {
Project::Folder &folder;
std::unordered_set<size_t> command_set;
StringSet<> excludeArgs;
StringSet<> exclude_args;
std::vector<GlobPattern> exclude_globs;

ProjectProcessor(Project::Folder &folder) : folder(folder) {
for (auto &arg : g_config->clang.excludeArgs)
excludeArgs.insert(arg);
if (arg.find_first_of("?*[") == std::string::npos)
exclude_args.insert(arg);
else if (Expected<GlobPattern> glob_or_err = GlobPattern::create(arg))
exclude_globs.push_back(std::move(*glob_or_err));
else
LOG_S(WARNING) << toString(glob_or_err.takeError());
}

bool ExcludesArg(StringRef arg) {
return exclude_args.count(arg) || any_of(exclude_globs,
[&](const GlobPattern &glob) { return glob.match(arg); });
}

// Expand %c %cpp ... in .ccls
Expand Down Expand Up @@ -103,7 +116,7 @@ struct ProjectProcessor {
}
if (ok)
args.push_back(A.data());
} else if (!excludeArgs.count(A)) {
} else if (!ExcludesArg(A)) {
args.push_back(arg);
}
}
Expand Down Expand Up @@ -384,7 +397,7 @@ void Project::LoadDirectory(const std::string &root, Project::Folder &folder) {
entry.args.reserve(args.size());
for (std::string &arg : args) {
DoPathMapping(arg);
if (!proc.excludeArgs.count(arg))
if (!proc.ExcludesArg(arg))
entry.args.push_back(Intern(arg));
}
entry.compdb_size = entry.args.size();
Expand Down

0 comments on commit 6a3cff6

Please sign in to comment.