refactor createChannel to use return error pattern #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenovich
reviewed
Nov 17, 2016
| if conn == nil { | ||
| log.Printf("Failed to open a channel: no connection") | ||
| return nil | ||
| return nil, nil //TODO Remove this guard clause |
There was a problem hiding this comment.
Why not to return nil, errors.New("Failed to open a channel: no connection")?
There was a problem hiding this comment.
I remove the guard clause in a different PR
There was a problem hiding this comment.
I did it like this because I was making some videos on refactoring.
|
+2 |
* remove nil checks * Refactor out Flag Arguments (#21) * Remove concept of autoclosing channel * Extract Method Refactor - Showing Composed Method Pattern (#22) * Simple extract method refactor * improved refactor * change AutoClosingChannel to ConnectionClosingChannel * Ba/errors video5 (#24) * Refactor out the consume essages function * Refactor create Queue, remove guard clause and unecessary code * continue refactoring out methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were breaking the error handling pattern in go. This is a very small change fixes the pattern for the createChannel method.