Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add support for loongarch64-unknown-linux-{gnu,musl} #2159

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Nov 14, 2024

No description provided.

Copy link
Owner

@briansmith briansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't want to add these to the CI matrix because they are just going to be running the same code that is already tested in other targets and the matrix is already too huge. However, I would like to accept the changes to cargo.sh and install-build-tools.sh. Could you revert the changes to ci.yml and leave the rest? Thanks!

@@ -578,6 +592,8 @@ jobs:
- aarch64-unknown-linux-gnu # Has assembly
- arm-unknown-linux-gnueabi # Has assembly
- armv7-unknown-linux-gnueabihf # Has assembly
- loongarch64-unknown-linux-gnu # Has assembly
- loongarch64-unknown-linux-musl # Has assembly
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no assembly in our code for these targets.

@heiher
Copy link
Contributor Author

heiher commented Dec 6, 2024

Thanks. I don't want to add these to the CI matrix because they are just going to be running the same code that is already tested in other targets and the matrix is already too huge. However, I would like to accept the changes to cargo.sh and install-build-tools.sh. Could you revert the changes to ci.yml and leave the rest? Thanks!

Thanks for your review. It's done.

@briansmith briansmith merged commit 8eee469 into briansmith:main Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants