limb::parse_big_endian_and_pad_consttime: Rewrite. #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2176 +/- ##
==========================================
- Coverage 96.93% 96.93% -0.01%
==========================================
Files 154 154
Lines 20147 20143 -4
Branches 468 464 -4
==========================================
- Hits 19530 19526 -4
Misses 512 512
Partials 105 105 ☔ View full report in Codecov by Sentry. |
briansmith
force-pushed
the
b/from_be
branch
6 times, most recently
from
cb443b4 to
ae6bf76
Compare
briansmith
changed the title
Limb::from_be_bytes instead of bit shifting.
Convert from bytes to limbs using `Limb::from_be_bytes`, in a generally more efficient manner, and in a way that avoids doing any arithmetic on the bytes. This addresses the TODO comment about making the constant-timedness of the code clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert from bytes to limbs using
Limb::from_be_bytes, in a generally more efficient manner, and in a way that avoids doing any arithmetic on the bytes. This addresses the TODO comment about making the constant-timedness of the code clearer.