CS

1) Tests/Admin/BaseFieldDescriptionTest.php (array_element_white_space_after_comma) 2) Tests/Controller/CRUDControllerTest.php (unneeded_control_parentheses, extra_empty_lines) 3) Controller/CRUDController.php (unneeded_control_parentheses) 4) Form/Type/AdminType.php (unneeded_control_parentheses)
bricelalu · Dec 2, 2015 · c5b0944 · c5b0944
1 parent ce50209
commit c5b0944
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 8 deletions.
diff --git a/Controller/CRUDController.php b/Controller/CRUDController.php
@@ -666,7 +666,7 @@ public function createAction()
      */
     protected function isPreviewRequested()
     {
-        return ($this->get('request')->get('btn_preview') !== null);
+        return $this->get('request')->get('btn_preview') !== null;
     }
 
     /**
@@ -676,7 +676,7 @@ protected function isPreviewRequested()
      */
     protected function isPreviewApproved()
     {
-        return ($this->get('request')->get('btn_preview_approve') !== null);
+        return $this->get('request')->get('btn_preview_approve') !== null;
     }
 
     /**
@@ -702,7 +702,7 @@ protected function isInPreviewMode()
      */
     protected function isPreviewDeclined()
     {
-        return ($this->get('request')->get('btn_preview_decline') !== null);
+        return $this->get('request')->get('btn_preview_decline') !== null;
     }
 
     /**

diff --git a/Form/Type/AdminType.php b/Form/Type/AdminType.php
@@ -65,7 +65,7 @@ public function setDefaultOptions(OptionsResolverInterface $resolver)
     {
         $resolver->setDefaults(array(
             'delete'          => function (Options $options) {
-                return ($options['btn_delete'] !== false);
+                return $options['btn_delete'] !== false;
             },
             'delete_options'  => array(
                 'type'         => 'checkbox',

diff --git a/Tests/Admin/BaseFieldDescriptionTest.php b/Tests/Admin/BaseFieldDescriptionTest.php
@@ -122,7 +122,7 @@ public function testGetValue()
          * Test with Two parameters int
          */
         $arg2 = 4;
-        $twoParameters = array($arg1,$arg2);
+        $twoParameters = array($arg1, $arg2);
         $description2 = new FieldDescription();
         $description2->setOption('code', 'getWithTwoParameters');
         $description2->setOption('parameters', $twoParameters);

diff --git a/Tests/Controller/CRUDControllerTest.php b/Tests/Controller/CRUDControllerTest.php
@@ -215,7 +215,6 @@ protected function setUp()
         $this->logger = $this->getMock('Psr\Log\LoggerInterface');
         $logger       = $this->logger; // php 5.3 BC
 
-
         $requestStack = null;
         if (Kernel::MINOR_VERSION > 3) {
             $requestStack = new \Symfony\Component\HttpFoundation\RequestStack();
@@ -1541,7 +1540,7 @@ public function testCreateActionSuccess($expectedToStringValue, $toStringValue)
                     return true;
                 }
 
-                return ($objectIn === $object);
+                return $objectIn === $object;
             }));
 
         $this->admin->expects($this->once())
@@ -1692,7 +1691,7 @@ public function testCreateActionAjaxSuccess()
                     return true;
                 }
 
-                return ($objectIn === $object);
+                return $objectIn === $object;
             }));
 
         $this->admin->expects($this->once())