Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make protected::traits public so that I can make types using Protected<> #65

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mahmoud-moursy
Copy link
Contributor

@mahmoud-moursy mahmoud-moursy commented Aug 15, 2024

I cannot use Protected memory directly in any of my types with generics because the traits module is private, so I could not actually write something like:

struct ProtectedMemory<X: traits::ReadWrite, traits::LockMode> {
  my_struct: Protected<HeapBytes, X, Y>
}

I cannot use Protected memory in any of my types because the `traits` module is private, so I could not actually write something like:

```rs
struct ProtectedMemory {
  my_struct: Protected<HeapBytes, ReadOnly, Locked>
}
```
Copy link

netlify bot commented Aug 15, 2024

Deploy Preview for dryoc-docs ready!

Name Link
🔨 Latest commit 3ef9325
🔍 Latest deploy log https://app.netlify.com/sites/dryoc-docs/deploys/66bdbd57acae580008f57807
😎 Deploy Preview https://deploy-preview-65--dryoc-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@brndnmtthws brndnmtthws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I don't think there's any downside to making this public. Thanks for the PR!

@brndnmtthws brndnmtthws added the enhancement New feature or request label Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.50%. Comparing base (dac80c0) to head (3ef9325).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files          43       43           
  Lines        3169     3169           
=======================================
  Hits         2076     2076           
  Misses       1093     1093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brndnmtthws brndnmtthws merged commit 49e01a6 into brndnmtthws:main Aug 15, 2024
9 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants