refactor: make watchFolders read-only everywhere (react-native-commun…

…ity#1132)
brodycj · Apr 25, 2020 · 5c83d59 · 5c83d59
1 parent bbb830e
commit 5c83d59
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 11 deletions.
diff --git a/packages/cli-server-api/src/devToolsMiddleware.ts b/packages/cli-server-api/src/devToolsMiddleware.ts
@@ -27,7 +27,7 @@ function escapePath(pathname: string) {
 type LaunchDevToolsOptions = {
   host?: string;
   port: number;
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
 };
 
 function launchDevTools(
@@ -48,7 +48,7 @@ function startCustomDebugger({
   watchFolders,
   customDebugger,
 }: {
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
   customDebugger: string;
 }) {
   const folders = watchFolders.map(escapePath).join(' ');

diff --git a/packages/cli-server-api/src/index.ts b/packages/cli-server-api/src/index.ts
@@ -35,7 +35,7 @@ export {messageSocketServer};
 
 type MiddlewareOptions = {
   host?: string;
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
   port: number;
 };
 

diff --git a/packages/cli-server-api/src/openStackFrameInEditorMiddleware.ts b/packages/cli-server-api/src/openStackFrameInEditorMiddleware.ts
@@ -10,7 +10,7 @@ import connect from 'connect';
 import rawBodyMiddleware from './rawBodyMiddleware';
 
 type Options = {
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
 };
 
 function getOpenStackFrameInEditorMiddleware({watchFolders}: Options) {

diff --git a/packages/cli/src/commands/server/middleware/MiddlewareManager.ts b/packages/cli/src/commands/server/middleware/MiddlewareManager.ts
@@ -22,7 +22,7 @@ import getDevToolsMiddleware from './getDevToolsMiddleware';
 
 type Options = {
   host?: string;
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
   port: number;
 };
 

diff --git a/packages/cli/src/commands/server/middleware/getDevToolsMiddleware.ts b/packages/cli/src/commands/server/middleware/getDevToolsMiddleware.ts
@@ -27,7 +27,7 @@ function escapePath(pathname: string) {
 type LaunchDevToolsOptions = {
   host?: string;
   port: number;
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
 };
 
 function launchDevTools(
@@ -48,7 +48,7 @@ function startCustomDebugger({
   watchFolders,
   customDebugger,
 }: {
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
   customDebugger: string;
 }) {
   const folders = watchFolders.map(escapePath).join(' ');

diff --git a/packages/cli/src/commands/server/middleware/openStackFrameInEditorMiddleware.ts b/packages/cli/src/commands/server/middleware/openStackFrameInEditorMiddleware.ts
@@ -10,7 +10,7 @@ import {launchEditor} from '@react-native-community/cli-tools';
 export default function getOpenStackFrameInEditorMiddleware({
   watchFolders,
 }: {
-  watchFolders: Array<string>;
+  watchFolders: ReadonlyArray<string>;
 }) {
   return (
     req: http.IncomingMessage & {rawBody: string},

diff --git a/packages/cli/src/tools/loadMetroConfig.ts b/packages/cli/src/tools/loadMetroConfig.ts
@@ -40,7 +40,7 @@ export interface MetroConfig {
     assetRegistryPath: string;
     assetPlugins?: Array<string>;
   };
-  watchFolders: string[];
+  watchFolders: ReadonlyArray<string>;
   reporter?: any;
 }
 

diff --git a/packages/tools/src/launchEditor.ts b/packages/tools/src/launchEditor.ts
@@ -153,7 +153,10 @@ function transformToAbsolutePathIfNeeded(pathName: string) {
   return pathName;
 }
 
-function findRootForFile(projectRoots: string[], fileName: string) {
+function findRootForFile(
+  projectRoots: ReadonlyArray<string>,
+  fileName: string,
+) {
   const absoluteFileName = transformToAbsolutePathIfNeeded(fileName);
   return projectRoots.find(root => {
     const absoluteRoot = transformToAbsolutePathIfNeeded(root);
@@ -165,7 +168,7 @@ let _childProcess: ChildProcess | null = null;
 function launchEditor(
   fileName: string,
   lineNumber: number,
-  projectRoots: string[],
+  projectRoots: ReadonlyArray<string>,
 ) {
   if (!fs.existsSync(fileName)) {
     return;