Skip to content

Commit

Permalink
Remove LayerBuilder and DefaultLayerBuilder (flutter#6256)
Browse files Browse the repository at this point in the history
This essentially reverts flutter#4197
as no one is (or soon will be) implementing an alternative LayerBuilder.
Let's just put everything in SceneBuilder to reduce the YAGNI
(you aren't gonna need it) smell. This will also make retained rendering
API changes much easier.
  • Loading branch information
liyuqian authored Sep 14, 2018
1 parent e817f2d commit b43b3e8
Show file tree
Hide file tree
Showing 8 changed files with 180 additions and 547 deletions.
4 changes: 0 additions & 4 deletions ci/licenses_golden/licenses_flutter
Original file line number Diff line number Diff line change
Expand Up @@ -248,10 +248,6 @@ FILE: ../../../flutter/assets/asset_manager.h
FILE: ../../../flutter/assets/asset_resolver.h
FILE: ../../../flutter/common/task_runners.cc
FILE: ../../../flutter/common/task_runners.h
FILE: ../../../flutter/flow/layers/default_layer_builder.cc
FILE: ../../../flutter/flow/layers/default_layer_builder.h
FILE: ../../../flutter/flow/layers/layer_builder.cc
FILE: ../../../flutter/flow/layers/layer_builder.h
FILE: ../../../flutter/flow/skia_gpu_object.cc
FILE: ../../../flutter/flow/skia_gpu_object.h
FILE: ../../../flutter/runtime/dart_isolate.cc
Expand Down
4 changes: 0 additions & 4 deletions flow/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,8 @@ source_set("flow") {
"layers/color_filter_layer.h",
"layers/container_layer.cc",
"layers/container_layer.h",
"layers/default_layer_builder.cc",
"layers/default_layer_builder.h",
"layers/layer.cc",
"layers/layer.h",
"layers/layer_builder.cc",
"layers/layer_builder.h",
"layers/layer_tree.cc",
"layers/layer_tree.h",
"layers/opacity_layer.cc",
Expand Down
235 changes: 0 additions & 235 deletions flow/layers/default_layer_builder.cc

This file was deleted.

104 changes: 0 additions & 104 deletions flow/layers/default_layer_builder.h

This file was deleted.

Loading

0 comments on commit b43b3e8

Please sign in to comment.