updated joi to version 12 (arb#39)

* updated joi to version 12

* Force Joi to escape html by default

* Add test for the escapeHTML default option for full coverage

* Not using default function parameters, Node 4 compatible

* Update README to document difference between joi and celebrate behavior

* Fixed README mistake

* Simplified default assignment for options

README.md

@@ -70,7 +70,7 @@ app.use(Celebrate.errors());
 The single exported function from `celebrate`. Returns a `function` with the middleware signature (`(req, res, next)`).
 
 - `schema` - a object where `key` can be one of `'params', 'headers', 'query', and 'body'` and the `value` is a [joi](https://github.com/hapijs/joi/blob/master/API.md) validation schema. Only the `key`s specified will be validated against the incoming `req` object. If you omit a key, that part of the `req` object will not be validated. A schema must contain at least one of the valid keys. 
-- `[options]` - `joi` [options](https://github.com/hapijs/joi/blob/master/API.md#validatevalue-schema-options-callback) that are passed directly into the `validate` function.
+- `[options]` - `joi` [options](https://github.com/hapijs/joi/blob/master/API.md#validatevalue-schema-options-callback) that are passed directly into the `validate` function. Defaults to `{ escapeHtml: true }`. This is differs from the Joi defaults since version 12.
 
 ### `Celebrate.errors()`
 

lib/index.js

@@ -12,6 +12,11 @@ const Celebrate = (schema, options) => {
   Assert.ifError(result.error);
   const rules = new Map();
 
+  const defaults = {
+    escapeHtml: true
+  };
+  options = Object.assign(defaults, options);
+
   const keys = Object.keys(schema);
   for (let i = 0; i < keys.length; i++) {
     const key = keys[i];

package.json

@@ -27,7 +27,7 @@
   "dependencies": {
     "escape-html": "1.0.3",
     "fastseries": "1.7.2",
-    "joi": "11.x.x"
+    "joi": "12.x.x"
   },
   "devDependencies": {
     "@types/express": "4.x.x",

test/index.js

@@ -255,6 +255,25 @@ describe('Celebrate Middleware', () => {
     });
   });
 
+  it('honors the escapeHtml Joi option', (done) => {
+    const middleware = Celebrate({
+      headers: {
+        accept: Joi.string().regex(/xml/)
+      }
+    }, { escapeHtml: false });
+
+    middleware({
+      headers: {
+        accept: 'application/json'
+      }
+    }, null, (err) => {
+      expect(err).to.exist();
+      expect(err.isJoi).to.be.true();
+      expect(err.details[0].message).to.equal('"accept" with value "application/json" fails to match the required pattern: /xml/');
+      done();
+    });
+  });
+
   describe('errors()', () => {
     it('responds with a joi error', (done) => {
       const handler = Celebrate.errors();