waddrmgr: add flags field on address row #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxcanfly
force-pushed
the
addr-flags
branch
2 times, most recently
from
cffb802 to
8b801c8
Compare
tuxcanfly
force-pushed
the
addr-flags
branch
8 times, most recently
from
b2c6083 to
0b5290b
Compare
tuxcanfly
force-pushed
the
addr-flags
branch
from
3480150 to
cf60027
Compare
|
This looks like a pretty small and reasonable change, and shouldn't be difficult to merge either. I'll review this soon so we can land it. |
|
Thanks. Yeah, this partially addresses the comments in #254. Still need to add the functionality to mark addresses as expired, but I think that could be done in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #254
Added a flags field
addrFlagson address row. Added upgrade path to migrate old used addrs and updated tests.