Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC v1.12.0: Register all services before call server.Serve. #562

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

gRPC v1.12.0: Register all services before call server.Serve. #562

wants to merge 1 commit into from

Conversation

nhandl3
Copy link

@nhandl3 nhandl3 commented Oct 12, 2018

Reference dcrwallet for this implementation.

@nhandl3 nhandl3 closed this Oct 23, 2018
@nhandl3 nhandl3 reopened this Oct 23, 2018
@nhandl3
gRPC v1.12.0: Register all services before call server.Serve.
acb9bf2 
Reference dcrwallet for this implementation.
@nhandl3
Copy link
Author

nhandl3 commented Dec 6, 2018

@Roasbeef Can you assign reviewer for this?

jakesylvestre
jakesylvestre approved these changes Mar 5, 2020
View reviewed changes
Copy link

@jakesylvestre jakesylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good/runs locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesylvestre jakesylvestre jakesylvestre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhandl3 @jakesylvestre