Skip to content

Commit

Permalink
Quote arguments used to invoke the renderer (google#393)
Browse files Browse the repository at this point in the history
I ran into issues with assets containing spaces; quoting the arguments (and to be safe, although I haven't tested this specifically, also the executable) allows those paths to be used.
  • Loading branch information
smalls authored Feb 28, 2019
1 parent 26708e9 commit 202866c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/filament-screenshot.sh
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ if [ -f $SCREENSHOT_OUTPUT_FILE ]; then
rm $SCREENSHOT_OUTPUT_FILE
fi

$GLTF_RENDERER_BIN -i $IBL_OUTPUT_PATH -w $RENDER_WIDTH -h $RENDER_HEIGHT -o $SCREENSHOT_OUTPUT_FILE $MODEL_PATH
"$GLTF_RENDERER_BIN" -i "$IBL_OUTPUT_PATH" -w $RENDER_WIDTH -h $RENDER_HEIGHT -o "$SCREENSHOT_OUTPUT_FILE" "$MODEL_PATH"

set +e
set +x
Expand Down

0 comments on commit 202866c

Please sign in to comment.