Skip to content

Commit

Permalink
CI: Bump Go and golangci-lint versions (thrasher-corp#1313)
Browse files Browse the repository at this point in the history
  • Loading branch information
thrasher- authored Aug 11, 2023
1 parent 2669266 commit b25037d
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ before_test:

test_script:
# test back-end
- go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
- go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.0
- '%GOPATH%\bin\golangci-lint.exe run --verbose'
- ps: >-
if($env:APPVEYOR_SCHEDULED_BUILD -eq 'true') {
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
with:
go-version: '1.20.x'
go-version: '1.21.x'
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: v1.52.2
version: v1.54.0
2 changes: 1 addition & 1 deletion .github/workflows/proto-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: 1.20.x
go-version: 1.21.x

- name: Setup build depends
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
on: [push, pull_request]
name: CI
env:
GO_VERSION: 1.20.x
GO_VERSION: 1.21.x
jobs:
backend-psql:
name: GoCryptoTrader back-end with PSQL
Expand Down
11 changes: 5 additions & 6 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ linters:
# - cyclop
# - deadcode // abandoned by its owner, replaced by unused
- decorder
- depguard
# - depguard
- dogsled
# - dupl
- dupword
Expand Down Expand Up @@ -68,6 +68,7 @@ linters:
- gomodguard
- goprintffuncname
- gosec
# - gosmopolitan
- grouper
# - ifshort // deprecated by its owner
# - importas
Expand All @@ -79,9 +80,10 @@ linters:
# - maintidx
- makezero
# - maligned // deprecated by its owner, replaced by govet 'fieldalignment'
- mirror
- misspell
# - musttag
- nakedret
# - nakedret
# - nestif
- nilerr
# - nilnil
Expand Down Expand Up @@ -117,16 +119,13 @@ linters:
- whitespace
# - wrapcheck
# - wsl
# - zerologlint

linters-settings:
govet:
check-shadowing: true
goconst:
min-occurrences: 6
depguard:
list-type: blacklist
# lll:
# line-length: 80 # NOTE: we'll enforce this at a later point
gocritic:
enabled-tags:
- performance
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.20 as build
FROM golang:1.21 as build
WORKDIR /go/src/github.com/thrasher-corp/gocryptotrader
COPY . .
RUN GO111MODULE=on go mod vendor
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
LDFLAGS = -ldflags "-w -s"
GCTPKG = github.com/thrasher-corp/gocryptotrader
LINTPKG = github.com/golangci/golangci-lint/cmd/golangci-lint@v1.52.2
LINTPKG = github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.0
LINTBIN = $(GOPATH)/bin/golangci-lint
GCTLISTENPORT=9050
GCTPROFILERLISTENPORT=8085
Expand Down

0 comments on commit b25037d

Please sign in to comment.