New sample file testing IfcLinearPlacement and related concepts #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are a number of IFCPRESENTATIONLAYERASSIGNMENT that references entities that doesn't exist. I also get some geometric errors (not telling me much at this stage). However, your issue on shape representation, I dont get in my version (6.0 - build 1658) of FZKViewer (when checking the IFC4X1 file). Otherwise, it looks fine to me! |
larswik
reviewed
Sep 17, 2020
pjanck
suggested changes
Sep 18, 2020
Co-authored-by: Stefan Jaud <[email protected]>
Co-authored-by: Stefan Jaud <[email protected]>
|
I would love to merge this pull request. However, I don't seem to have the permissions... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Sample for IfcLinearPlacement
Fixes: likely nothing but might raise attention to issues around the linear positioning concept
Changes and improvements proposed by this pull request
fyi:
@jmirtsch @pjanck @NigelPMPeters @SergejMuhic @larswik
IFC4.3 Unit test
Unit test
not decided yet - file could help developers to get a solid starting point when implementing alignment and linear referencing methods in recent IFC versions
Review requested
IfcShapeRepresentation:Any feedback and suggestions for improvements are highly appreciated