Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lee gregory12d patch 1 #28

Closed

Conversation

LeeGregory12d
Copy link

ATTENTION: This template provides structure for

  • a general pull request and
  • a specific pull request in scope of IFC4.3 validation work within IFC Infrastructure Extension Deployment project.
    Please fill in the corresponding section(s) and delete the rest.

General pull request

Fixes # . reference the issue fixed through this pull request

Changes and improvements proposed by this pull request

  • list all functions / files / changes you have made

Use @[username] to gain attention by potential reviewers.

IFC4.3 Unit test

Unit test

provide a short description

Review requested

  • List all functions/concepts/entities you have added/changed/improved

@pjanck

Link to external documentation

optional

Instructions

  • provide a descriptive title

Added new UT with supporting documentation
Expanded UT with ...
Corrected / Amended / Updated ...

  • prepend the title with [UT] <title> to enable easier management
  • mark as WIP if work in progress

WIP: [UT] <title>

  • label the pull request with infra depl
  • please set at least @pjanck as a reviewer and add others as needed
  • delete this section

Copy link

@pjanck pjanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM.

@pjanck pjanck self-assigned this Oct 13, 2020
@pjanck pjanck closed this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants