Skip to content

Commit

Permalink
percpu: end chunk area maps page aligned for the populated bitmap
Browse files Browse the repository at this point in the history
The area map allocator manages the first chunk area by hiding all but
the region it is responsible for serving in the area map. To align this
with the populated page bitmap, end_offset is introduced to keep track
of the delta to end page aligned. The area map is appended with the
page aligned end when necessary to be in line with how the bitmap
allocator requires the ending to be aligned with the LCM of PAGE_SIZE
and the size of each bitmap block. percpu_stats is updated to ignore
this region when present.

Signed-off-by: Dennis Zhou <[email protected]>
Reviewed-by: Josef Bacik <[email protected]>
Signed-off-by: Tejun Heo <[email protected]>
  • Loading branch information
dennisszhou authored and htejun committed Jul 26, 2017
1 parent 10edf5b commit 6b9d7c8
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 2 deletions.
3 changes: 3 additions & 0 deletions mm/percpu-internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ struct pcpu_chunk {
int start_offset; /* the overlap with the previous
region to have a page aligned
base_addr */
int end_offset; /* additional area required to
have the region end page
aligned */
int nr_populated; /* # of populated pages */
unsigned long populated[]; /* populated bitmap */
};
Expand Down
5 changes: 3 additions & 2 deletions mm/percpu-stats.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,19 @@ static int find_max_map_used(void)
static void chunk_map_stats(struct seq_file *m, struct pcpu_chunk *chunk,
int *buffer)
{
int i, s_index, last_alloc, alloc_sign, as_len;
int i, s_index, e_index, last_alloc, alloc_sign, as_len;
int *alloc_sizes, *p;
/* statistics */
int sum_frag = 0, max_frag = 0;
int cur_min_alloc = 0, cur_med_alloc = 0, cur_max_alloc = 0;

alloc_sizes = buffer;
s_index = (chunk->start_offset) ? 1 : 0;
e_index = chunk->map_used - ((chunk->end_offset) ? 1 : 0);

/* find last allocation */
last_alloc = -1;
for (i = chunk->map_used - 1; i >= s_index; i--) {
for (i = e_index - 1; i >= s_index; i--) {
if (chunk->map[i] & 1) {
last_alloc = i;
break;
Expand Down
9 changes: 9 additions & 0 deletions mm/percpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -715,12 +715,16 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(void *base_addr,
int init_map_size)
{
struct pcpu_chunk *chunk;
int region_size;

region_size = PFN_ALIGN(start_offset + map_size);

chunk = memblock_virt_alloc(pcpu_chunk_struct_size, 0);
INIT_LIST_HEAD(&chunk->list);
INIT_LIST_HEAD(&chunk->map_extend_list);
chunk->base_addr = base_addr;
chunk->start_offset = start_offset;
chunk->end_offset = region_size - chunk->start_offset - map_size;
chunk->map = map;
chunk->map_alloc = init_map_size;

Expand All @@ -735,6 +739,11 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(void *base_addr,
chunk->map[2] = (chunk->start_offset + chunk->free_size) | 1;
chunk->map_used = 2;

if (chunk->end_offset) {
/* hide the end of the bitmap */
chunk->map[++chunk->map_used] = region_size | 1;
}

return chunk;
}

Expand Down

0 comments on commit 6b9d7c8

Please sign in to comment.