Skip to content

Commit

Permalink
ArmPlatformPkg/Sec: Move 'ArmPlatformSecExtraAction' before we set NS…
Browse files Browse the repository at this point in the history
…ACR & SCR

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@13061 6f19259b-4bc3-4df7-8a09-765794883524
  • Loading branch information
oliviermartin committed Feb 28, 2012
1 parent a853088 commit 3d93aea
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 13 deletions.
27 changes: 15 additions & 12 deletions ArmPlatformPkg/Sec/Sec.c
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ CEntryPoint (
{
CHAR8 Buffer[100];
UINTN CharCount;
UINTN JumpAddress;

// Invalidate the data cache. Doesn't have to do the Data cache clean.
ArmInvalidateDataCache();
Expand Down Expand Up @@ -100,10 +101,6 @@ CEntryPoint (

// Test if Trustzone is supported on this platform
if (FixedPcdGetBool (PcdTrustzoneSupport)) {
// Ensure the Monitor Stack Base & Size have been set
ASSERT(PcdGet32(PcdCPUCoresSecMonStackBase) != 0);
ASSERT(PcdGet32(PcdCPUCoreSecMonStackSize) != 0);

if (ArmIsMpCore()) {
// Setup SMP in Non Secure world
ArmCpuSetupSmpNonSecure (GET_CORE_ID(MpId));
Expand All @@ -121,7 +118,11 @@ CEntryPoint (
// Status Register as the the current one (CPSR).
copy_cpsr_into_spsr ();

NonTrustedWorldTransition (MpId);
// Call the Platform specific function to execute additional actions if required
JumpAddress = PcdGet32 (PcdFvBaseAddress);
ArmPlatformSecExtraAction (MpId, &JumpAddress);

NonTrustedWorldTransition (MpId, JumpAddress);
}
ASSERT (0); // We must never return from the above function
}
Expand All @@ -131,6 +132,8 @@ TrustedWorldInitialization (
IN UINTN MpId
)
{
UINTN JumpAddress;

//-------------------- Monitor Mode ---------------------

// Set up Monitor World (Vector Table, etc)
Expand All @@ -155,25 +158,25 @@ TrustedWorldInitialization (
// Transfer the interrupt to Non-secure World
ArmGicSetupNonSecure (PcdGet32(PcdGicDistributorBase), PcdGet32(PcdGicInterruptInterfaceBase));

// Call the Platform specific fucntion to execute additional actions if required
JumpAddress = PcdGet32 (PcdFvBaseAddress);
ArmPlatformSecExtraAction (MpId, &JumpAddress);

// Write to CP15 Non-secure Access Control Register
ArmWriteNsacr (PcdGet32 (PcdArmNsacr));

// CP15 Secure Configuration Register
ArmWriteScr (PcdGet32 (PcdArmScr));

NonTrustedWorldTransition (MpId);
NonTrustedWorldTransition (MpId, JumpAddress);
}

VOID
NonTrustedWorldTransition (
IN UINTN MpId
IN UINTN MpId,
IN UINTN JumpAddress
)
{
UINTN JumpAddress;

JumpAddress = PcdGet32 (PcdFvBaseAddress);
ArmPlatformSecExtraAction (MpId, &JumpAddress);

// If PcdArmNonSecModeTransition is defined then set this specific mode to CPSR before the transition
// By not set, the mode for Non Secure World is SVC
if (PcdGet32 (PcdArmNonSecModeTransition) != 0) {
Expand Down
3 changes: 2 additions & 1 deletion ArmPlatformPkg/Sec/SecInternal.h
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ TrustedWorldInitialization (

VOID
NonTrustedWorldTransition (
IN UINTN MpId
IN UINTN MpId,
IN UINTN JumpAddress
);

VOID
Expand Down

0 comments on commit 3d93aea

Please sign in to comment.