[FLINK-20383][runtime] Fix race condition in notification.

Notification happens outside of lock, so between non-null check and actual notification, readView could have been released.
burkaygur · Nov 27, 2020 · fd23b35 · fd23b35
1 parent 562e5a4
commit fd23b35
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/...me/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java b/...me/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
@@ -496,12 +496,14 @@ private boolean shouldNotifyDataAvailable() {
 	}
 
 	private void notifyDataAvailable() {
+		final PipelinedSubpartitionView readView = this.readView;
 		if (readView != null) {
 			readView.notifyDataAvailable();
 		}
 	}
 
 	private void notifyPriorityEvent(int prioritySequenceNumber) {
+		final PipelinedSubpartitionView readView = this.readView;
 		if (readView != null) {
 			readView.notifyPriorityEvent(prioritySequenceNumber);
 		}