fix string freeze issue for ruby 2.3

burstorm · Apr 13, 2016 · c2e720e · c2e720e
1 parent 2d7a78a
commit c2e720e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/fog/storage.rb b/lib/fog/storage.rb
@@ -42,7 +42,7 @@ def self.directories
     def self.get_body_size(body)
       if body.respond_to?(:encoding)
         original_encoding = body.encoding
-        body.force_encoding('BINARY')
+        body = body.dup.force_encoding('BINARY')
       end
 
       size = if body.respond_to?(:bytesize)

diff --git a/spec/storage_spec.rb b/spec/storage_spec.rb
@@ -67,6 +67,7 @@ module Fog
       module Storage
         class BothWays
           attr_reader :args
+
           def initialize(args)
             @args = args
           end
@@ -105,5 +106,14 @@ def initialize(args)
         skip
       end
     end
+
+    it "respects frozen strings" do
+      if RUBY_VERSION >= "2.3.0"
+        body = "foo".freeze
+        Fog::Storage.get_body_size(body)
+      else
+        skip
+      end
+    end
   end
-end
+end