Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem + CLI #1

Merged
merged 11 commits into from
Apr 29, 2024
Merged

Gem + CLI #1

merged 11 commits into from
Apr 29, 2024

Conversation

claytongentry
Copy link
Member

Introduces a series of enhancements to the Manifolds project's CLI tool. Key changes include refactoring the CLI class, updating testing practices to align with RSpec conventions, and preparing the CLI tool for easy distribution via Homebrew. These changes ensure that the tool is not only more robust but also easier for users to install and manage.

Key Changes:

CLI Refactoring:

  • Simplified the CLI class naming to CLI from ManifoldsCLI to better align with the project context.
  • Updated the CLI initialization code to prevent execution when included in other modules (e.g., during testing).

RSpec Testing Enhancements:

  • Introduced named subjects in RSpec tests to clear the RSpec/NamedSubject RuboCop offenses and improve test readability.
  • Split expectations into separate tests to adhere to the RSpec/MultipleExpectations guideline.
  • Modified test setups to use allow and have_received for better practice in message expectation.

Preparation for Homebrew Distribution:

  • Packaged the CLI as a Ruby gem for easier distribution and version management.
  • Created a Homebrew tap and formula for the CLI, allowing users to easily install the tool using Homebrew.

RuboCop Compliance:

  • Addressed all RuboCop offenses to ensure the codebase adheres to Ruby and RSpec best practices, enhancing code quality and maintainability.

@claytongentry claytongentry merged commit 1462045 into master Apr 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant