Skip to content

Commit

Permalink
Merge bitcoin#20290: fuzz: Fix DecodeHexTx fuzzing harness issue
Browse files Browse the repository at this point in the history
28f8cb1 fuzz: Fix DecodeHexTx fuzzing harness issue (practicalswift)

Pull request description:

  Fix `DecodeHexTx` fuzzing harness issue.

  Before this patch:

  ```
  $ src/test/fuzz/decode_tx
  decode_tx: test/fuzz/decode_tx.cpp:29:
      void test_one_input(const std::vector<uint8_t> &):
      Assertion `result_try_witness_and_maybe_no_witness' failed.
  …
  ```

  After this patch:

  ```
  $ src/test/fuzz/decode_tx
  …
  ```

ACKs for top commit:
  MarcoFalke:
    review ACK 28f8cb1

Tree-SHA512: 2ed11b2f00a4c6fa3e8eea76a2a37d89a4b8d52815264676fe3de0a26ad7906cfafda9b843ceede2fd428815472e01fd1f87afb851282a8c7839bd4c87dc382b
  • Loading branch information
MarcoFalke committed Nov 3, 2020
2 parents 5174b53 + 28f8cb1 commit 218fe60
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/test/fuzz/decode_tx.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
if (result_try_witness_and_maybe_no_witness) {
assert(result_try_no_witness || result_try_witness);
}
// if (result_try_no_witness) { // Uncomment when https://github.com/bitcoin/bitcoin/pull/17775 is merged
if (result_try_witness) { // Remove stop-gap when https://github.com/bitcoin/bitcoin/pull/17775 is merged
if (result_try_no_witness) {
assert(result_try_witness_and_maybe_no_witness);
}
}

0 comments on commit 218fe60

Please sign in to comment.